Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for scheduled object creation #19

Merged
merged 12 commits into from
Jan 15, 2024
Merged

Support for scheduled object creation #19

merged 12 commits into from
Jan 15, 2024

Conversation

yunussandikci
Copy link
Contributor

Hi 👋
This PR adds a new CRD called ScheduledResource which allows you to schedule an object creation in the future. It's an idea coming from a community member
You can also combine it with expire annotation, and basically mayfly will create and remove some objects only for a temprary time in the future.

Please feel free to share your opinion to make this PR better!

Example:

apiVersion: cloud.namecheap.com/v1alpha1
kind: ScheduledResource
metadata:
  annotations:
    mayfly.cloud.namecheap.com/expire: 60m
  name: example
  namespace: default
spec:
  in: 30m
  content: |
    apiVersion: v1
    kind: Secret
    metadata:
      name: example
      namespace: default
      annotations:
        mayfly.cloud.namecheap.com/expire: 30m
    data:
      .secret-file: dmFsdWUtMg0KDQo=
status:
  condition: Scheduled

Thanks!

cc @glourenco

@sandromodarelli
Copy link
Contributor

you're a 🚀. i really like the implementation. maybe, before merging it, we can improve the documentation to have some human friendly explanation about how the ScheduledResource works. thank you for your great work 🙏

@glourenco
Copy link
Contributor

I've edited the readme to add the ScheduledResource info

@glourenco glourenco self-requested a review December 4, 2023 10:14
@eshepelyuk
Copy link

Curious if this going to be merged any time soon ?

@sandromodarelli sandromodarelli linked an issue Jan 12, 2024 that may be closed by this pull request
[proposal] Add a functionality to remove object on exact date \ time #20
Closed
@yunussandikci yunussandikci merged commit 6a068db into main Jan 15, 2024
1 check passed
@yunussandikci yunussandikci deleted the create-support branch January 15, 2024 10:37
@yunussandikci yunussandikci removed a link to an issue Jan 15, 2024
[proposal] Add a functionality to remove object on exact date \ time #20
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glourenco glourenco glourenco approved these changes

@sandromodarelli sandromodarelli Awaiting requested review from sandromodarelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yunussandikci @sandromodarelli @glourenco @eshepelyuk